Re: Re* [PATCH 8/9] fast-export: respect the possibly-overridden default branch name
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 12, 2020, 12:03 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2006121401420.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqpna5bq2l.fsf_-_@gitster.c.googlers.com>
Hi Junio,
On Thu, 11 Jun 2020, Junio C Hamano wrote:
Show 34 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> It is a good argument. I also heard a rumor that often branch names > >> contain codewords given to pre-released hardware that are highly > >> confidential in certain circles, and heard that it is one of the > >> reasons why Gerrit has server side ACL that lets you hide some > >> branches from authenticated users that can access other branches. > > > > Yes, branch names in general _can_ contain information users may prefer to > > keep private. > > > > However, we're not talking about branch names in general. We are talking > > about the default name of the main branch, to be picked in _all_ of your > > new repositories. > > No, we are talking about the name of the branch, chosen to be the > primary one, in one particular repository whose contents are > exported via fast-export with explicit request from the user to > anonymize end-user data. > > > Yes. And you're unlikely to configure the default name to be used for all > > of your future `git init` operations to be something non-generic. > > > > Now, if you suggest that `git fast-export --anonymize` should either not > > special-case the main branch, or at least have a configurable set of names > > it skips from protecting, then I will be much more in favor of those > > suggestions. However, those suggestions are quite a bit orthogonal to the > > patch series at hand, so I would want to discuss them in their own code > > contribution instead of here. > > > I think after writing the message about your "two variable" > approach, you would retract the "something non-generic" part in the > above sentence.
You are absolutely correct!
> [...] > -- >8 -- > Subject: [PATCH] fast-export: do anonymize the primary branch name
I like this approach a lot. Do you want me to integrate it into this patch series, or rather have it as a stand-alone patch?
Ciao, Dscho