Re: [PATCH 1/9] init: allow overriding the default branch name for new repositories

From: Alban Gruin <alban.gruin@gmail.com>
Date: Jun 13, 2020, 18:01 UTC
Message-ID: <731205c8-7d4b-d87a-17d1-520fdec7375d@gmail.com>
In-Reply-To: <xmqqwo4di49l.fsf@gitster.c.googlers.com>

Hi Junio,

Le 12/06/2020 à 01:14, Junio C Hamano a écrit :

Show 19 quoted lines

> Alban Gruin <alban.gruin@gmail.com> writes:
> 
>> Why adding yet another environment variable instead of relying only on a
>> config option?  I understand it's for the tests, but can't we add a
>> shell function in test-lib.sh (and friends) that tries to read
>> `GIT_TEST_DEFAULT_BRANCH_NAME', and, if it exists, sets
>> `core.defaultBranchName'?
> 
> Can you produce such a patch that does it cleanly?  My knee jerk
> reaction is that I would suspect that you end up having to touch
> many places in the t/ scripts, but if you prove otherwise, that
> would certainly be appreciated.
> 
> And no, 
> 
>     git () { command git -c core.defaultBranchName=master "$@" }
> 
> is not an acceptable solution.
>

I wanted to to do something like this:

  if test -n "$GIT_TEST_DEFAULT_BRANCH_NAME";
  then
      git config core.defaultBranchName "$GIT_TEST_DEFAULT_BRANCH_NAME"
  fi

But since we do not have a repository to store the config, it won't work. Sorry for the noise.

Alban