Re: [PATCH v2 02/12] fmt-merge-msg: introduce a way to override the main branch name
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 18, 2020, 13:15 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2006181514430.54@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqeeqdv9e8.fsf@gitster.c.googlers.com>
Hi,
On Wed, 17 Jun 2020, Junio C Hamano wrote:
Show 17 quoted lines
> Jeff King <peff@peff.net> writes: > > > I'm not sure if this check_refname_format() is valid, though. IIRC we've > > had issues where "ONELEVEL" was used to check a branch name, but misses > > some cases. The more full check done by strbuf_check_branch_ref() > > actually creates the full refname and checks that. It also catches stuff > > like refs/heads/HEAD. > > Yup. > > I actually am in favor of removing special casing of a single branch > done by fmt-merge-msg and fast-export --anonymize, so this may not > matter. > > We still need a mechanism to allow users specify the default name to > be given to the first branch "git init" creates and used by "git clone" > as a fallback name when it cannot infer what the other side uses, though.
All right, `core.mainBranch` will go, then, and `init.defaultBranch` will stay and I will check the full ref.
Thank you for your help improving the patch series, Dscho