Re: [PATCH 8/9] fast-export: respect the possibly-overridden default branch name
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 11, 2020, 13:57 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2006111556090.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CAOjrSZvm9QNUttUNVBEUMPJ8zgYEoAnSPN5_6N5uwpiM1sVrcQ@mail.gmail.com>
Hi Matt,
On Wed, 10 Jun 2020, Matt Rogers wrote:
Show 12 quoted lines
> > - * We also leave "master" as a special case, since it does not reveal > > - * anything interesting. > > + * We also leave the default branch name as a special case, since it > > + * does not reveal anything interesting. > > */ > I feel this is a weird thing to do, since you're trying to anonymize the branch > name,and now the default branch is identifiable with your config file. For > example, if the default branch contains the name of my project/repo then this > sounds like a recipe for accidentally sharing it. I feel a better > alternative would > be to exclude nothing from the anonymization or the proposed default default > branch name
I don't think that the name of the main branch should be subject to anonymizing, whether it be `master` or anything else.
Ciao, Dscho