Re: [PATCH v5 2/2] submodule: pass on http.extraheader config settings

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 28, 2016, 19:52 UTC
Message-ID: <xmqqoa8t4il8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kYoRP=rkfaL+rLapmvouUdPxXGBr-KWOLhL94bYB1B2-w@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 8 quoted lines

> So when going with that philosophy, the user might be missing
> switches like
>
>     -c-for-this-repo-only core.worktree=... -c
> submodule.worktree=align-relative-to-parent
>
> i.e. when shifting the responsibility to the user, we need to have
> switches to pass options to the repository or a subset of submodules?

I think that is an excellent illlustration of the issue by an example of what we shouldn't do ;-)

"git" is not always about submodules, so "-c-but-not-for-submodules" option does not belong to "git" wrapper.

Users use "git -c" and hope to affect what happens in submodules, only because "git submodule" support is still immature and does not have options to do that. You certainly smell a linkage between "pass options to a selected subset of submodules" and your recent "give labels to submodules so that they can be named with *group syntax" topic, no?