Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 4, 2016, 11:20 UTC
Message-ID: <alpine.DEB.2.20.1605041316160.9313@virtualbox>
In-Reply-To: <xmqq7ffajmvz.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 4 May 2016, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >>   submodule: pass on http.extraheader config settings
> >
> > IMHO this should come on top of jk/submodule-config-sanitize-fix (I was
> > surprised at first that your test worked at all, but that is because it
> > is using "clone", which is the one code path that works).
> 
> Yes.

Okay.

Show 13 quoted lines

> > But I think we are waiting on going one of two paths:
> >
> >   1. drop sanitizing entirely
> >
> >   2. fix sanitizing and add more variables to it
> >
> > If we go the route of (2), then we'd want my fix topic and this patch.
> > And if not, then we don't need any of it (just a patch dropping the
> > filtering, which AFAIK nobody has written yet).
> 
> Doubly yes.  That is why I didn't pick up 2/2 in the previous round
> and also jk/submodule-config-sanitize-fix is not in 'next' for the
> same reason.

Okay. It was not clear to me that the indentation was not the reason it was ignored.

Show 5 quoted lines

> I agree with you that we have not yet reached concensus on which one
> of the two we would want to take.  I was sort of surprised to see
> 2/2 sent again, after seeing that Dscho sounded strongly in favor of
> not filtering the passed configuration variables, which would make
> the patch unnecessary.

Hah, my opinion matters after all.

Yes, I am in favor of not filtering any config settings passed through the command-line.

But traditionally, I did not always get what I strongly preferred, and in this case it is really important to me that support for `git -c http.extraheader=... submodule ...` be part of an official Git version soon.

I just *really* would hate for, say, 2.9.0 to be released with `git -c http.extraheader=Hello:\ Junio submodule update --init` not working as intended.

Ciao, Dscho