Re: [PATCH v5 2/2] submodule: pass on http.extraheader config settings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 29, 2016, 12:48 UTC
Message-ID: <alpine.DEB.2.20.1604291443561.9313@virtualbox>
In-Reply-To: <alpine.DEB.2.20.1604291429560.9313@virtualbox>

Hi Junio,

On Fri, 29 Apr 2016, Johannes Schindelin wrote:

Show 18 quoted lines

> On Thu, 28 Apr 2016, Junio C Hamano wrote:
> 
> > Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> > 
> > > -     if (starts_with(var, "credential."))
> > > +     if (starts_with(var, "credential.") ||
> > > +                     (starts_with(var, "http.") &&
> > > +                      ends_with(var, ".extraheader")))
> > 
> > I know you are fond of indenting with HT without aligning things,
> > but this is going too far in the quest of making the code
> > unreadable.
> 
> Hah. I am actually not fond of anything there, but I go with the default
> in my vim when selecting lines and pressing the '=' key...
> 
> If you know off-hand how to teach my vim to use your preferred indenting,
> I'll gladly just brow-beat it into submission.

For the record, I think the default in vim is to indent two tabs after an unclosed parenthesis in an `if` line (the "(2s" just below http://vimdoc.sourceforge.net/htmldoc/indent.html#javascript-indenting in the default cinoptions). The "(0" setting fixes this, I think, so I forced my vim to use

	cinoptions=>s,e0,n0,f0,{0,}0,^0,L-1,:s,=s,l0,b0,gs,hs,ps,ts,is,+s,c3,C0,/0,(0,us,U0,w0,W0,m0,j0,J0,)20,*70,#0

from now on.

Ciao, Dscho