Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 10, 2016, 06:53 UTC
Message-ID: <alpine.DEB.2.20.1605100832350.4092@virtualbox>
In-Reply-To: <xmqqwpn3w5c7.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 9 May 2016, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Okay, I already force-pushed my extra-http-header branch and the next
> > iteration will sport this paragraph.
> 
> The new explanation is well written and can and should also replace the
> comment before the implementation in the configuration file to help
> readers.

I picked your commit and force-pushed my branch; it will be part of the next iteration.

> To be honest, I do not quite understand why you call it "ugly hack"
> at all.

Well, it is convoluted. I would have preferred to say "if this condition is not met or that condition is not met, fail". Instead I had to say "If` these two conditions are met, proceed as before. Otherwise, fail."

And of course its ugliness increased in my mind because I had to go through so many iterations until it finally worked. Not really straight-forward a solution.

Show 5 quoted lines

> > Hopefully your patch to remove the -c ... sanitizing makes it to
> > `master` soon, then I can submit my next iteration.
> 
> Or we can just merge that "do not sanitize" branch in, and then queue
> the "next iteration" which I'd assume would only be the test addition?

I'll prepare something.

Ciao, Dscho