Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

From: Lars Schneider <larsxschneider@gmail.com>
Date: May 9, 2016, 07:56 UTC
Message-ID: <BC0E627C-416C-41AA-9D09-68634845BC3D@gmail.com>
In-Reply-To: <f29dac327aeac23677aec955f5b46a7a4702abfe.1462774709.git.johannes.schindelin@gmx.de>

On 09 May 2016, at 08:19, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 9 quoted lines

> To test that extra HTTP headers are passed correctly, t5551 verifies that
> a fetch succeeds when two required headers are passed, and that the fetch
> does not succeed when those headers are not passed.
> 
> However, this test would also succeed if the configuration required only
> one header. As Apache's configuration is notoriously tricky (this
> developer frequently requires StackOverflow's help to understand Apache's
> documentation), especially when still supporting the 2.2 line, let's just
> really make sure that the test verifies what we want it to verify.

Haha. Me, too :-) After I wasn't able to find a working solution myself I posted a question on ServerFault [1] ... I will test your solution tomorrow!

Cheers, Lars

[1] https://serverfault.com/questions/775515/requireall-require-expr-equivalent-in-apache-2-2-22-to-check-for-headers