Re: [PATCH v5 2/2] submodule: pass on http.extraheader config settings

From: Stefan Beller <sbeller@google.com>
Date: Apr 28, 2016, 21:12 UTC
Message-ID: <CAGZ79kY8s9pV_Lb8D0OYCrarDyC6v2U0VkaJSJBnviditYK9aA@mail.gmail.com>
In-Reply-To: <20160428210342.GB12268@sigill.intra.peff.net>

On Thu, Apr 28, 2016 at 2:03 PM, Jeff King <peff@peff.net> wrote:

Show 16 quoted lines

> On Thu, Apr 28, 2016 at 12:52:03PM -0700, Junio C Hamano wrote:
>
>> "git" is not always about submodules, so "-c-but-not-for-submodules"
>> option does not belong to "git" wrapper.
>>
>> Users use "git -c" and hope to affect what happens in submodules,
>> only because "git submodule" support is still immature and does not
>> have options to do that.  You certainly smell a linkage between
>> "pass options to a selected subset of submodules" and your recent
>> "give labels to submodules so that they can be named with *group
>> syntax" topic, no?
>
> Keep in mind that submodule interactions may be triggered from other
> non-submodule commands. So "git fetch", for instance, may end up caring
> about whether you pass "http.*" or "credential.*" down to the
> submodules.

Or clone. I recently sent origin/sb/clone-shallow-passthru which adds more options to a non-submodule command. I think a command line option there is better than a "git -c $OPTION"

> I do not think "fetch" should grow submodule-specific
> options, so that pretty much leaves "git" options as the only place
> left.

I would rather see it in fetch as in the generic Git?

Stefan

>
> -Peff