Re: [PATCH v7 2/3] t5551: make the test for extra HTTP headers more robust

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 9, 2016, 08:13 UTC
Message-ID: <alpine.DEB.2.20.1605091011420.4092@virtualbox>
In-Reply-To: <20160509080544.GB14383@sigill.intra.peff.net>

Hi Peff,

do you sleep at all?

On Mon, 9 May 2016, Jeff King wrote:

Show 16 quoted lines

> On Mon, May 09, 2016 at 08:19:00AM +0200, Johannes Schindelin wrote:
> 
> >  test_expect_success 'custom http headers' '
> > -	test_must_fail git fetch "$HTTPD_URL/smart_headers/repo.git" &&
> > +	test_must_fail git -c http.extraheader="x-magic-two: cadabra" \
> > +		fetch "$HTTPD_URL/smart_headers/repo.git" &&
> >  	git -c http.extraheader="x-magic-one: abra" \
> >  	    -c http.extraheader="x-magic-two: cadabra" \
> >  	    fetch "$HTTPD_URL/smart_headers/repo.git"
> 
> This loses the 0-header check, but I don't think that is particularly
> interesting to us (I had originally wanted to double-check that our
> apache config worked at all in the absence of this feature, but I think
> it is OK for the 1-header case to cover this; if our code is so buggy we
> accidentally send 0 headers in the first command, we'll catch that,
> too).

Yeah, a faulty Apache config will unfortunately *skip* the entire test, as httpd refuses to start.

And I also considered testing 0-header and 1st header only. But as you know, Git's test suite takes already 3.5h in a moderately sized Windows VM, so I am really reluctant to add overly extensive tests.

> So looks good to me.

Thanks, Dscho