Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2016, 07:13 UTC
Message-ID: <xmqqbn4es7uz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1605100832350.4092@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

>> To be honest, I do not quite understand why you call it "ugly hack"
>> at all.
>
> Well, it is convoluted. I would have preferred to say "if this condition
> is not met or that condition is not met, fail". Instead I had to say "If`
> these two conditions are met, proceed as before. Otherwise, fail."
>
> And of course its ugliness increased in my mind because I had to go
> through so many iterations until it finally worked. Not really
> straight-forward a solution.

To my eyes without your battle scar, it felt more natural to say "If somebody says he is user $U and gives a password $P, let him in; keep everybody else out" when configuring a server than saying "Fail anybody whose user name is not $U or who says his password is not $P". I can certainly understand if somebody who has spent a lot of effort to make things _fail_ finds the latter more natural.