Re: [PATCH v5 2/2] submodule: pass on http.extraheader config settings

From: Jeff King <peff@peff.net>
Date: Apr 28, 2016, 21:03 UTC
Message-ID: <20160428210342.GB12268@sigill.intra.peff.net>
In-Reply-To: <xmqqoa8t4il8.fsf@gitster.mtv.corp.google.com>

On Thu, Apr 28, 2016 at 12:52:03PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> "git" is not always about submodules, so "-c-but-not-for-submodules"
> option does not belong to "git" wrapper.
> 
> Users use "git -c" and hope to affect what happens in submodules,
> only because "git submodule" support is still immature and does not
> have options to do that.  You certainly smell a linkage between
> "pass options to a selected subset of submodules" and your recent
> "give labels to submodules so that they can be named with *group
> syntax" topic, no?

Keep in mind that submodule interactions may be triggered from other non-submodule commands. So "git fetch", for instance, may end up caring about whether you pass "http.*" or "credential.*" down to the submodules. I do not think "fetch" should grow submodule-specific options, so that pretty much leaves "git" options as the only place left.

-Peff