Re: [PATCH v4] http: support sending custom HTTP headers

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2016, 21:03 UTC
Message-ID: <xmqq4mam932j.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160427193055.GA6727@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 22 quoted lines

> On Wed, Apr 27, 2016 at 02:20:37PM +0200, Johannes Schindelin wrote:
>
>> The only change vs v3 is that I replaced my flimsical test by Peff's (with
>> *one* change: I realized that we need to group the Require statements in a
>> <RequireAll> block when I tried to verify that the test fails when I
>> modify the first header).
>
> Whoops, I didn't actually test that case. Thanks for catching (as you
> might guess, I wanted to make sure we handle multiple values correctly).
>
>>  Documentation/config.txt    |  6 ++++++
>>  http-push.c                 | 10 +++++-----
>>  http.c                      | 35 ++++++++++++++++++++++++++++++++---
>>  http.h                      |  1 +
>>  remote-curl.c               |  4 ++--
>>  t/lib-httpd/apache.conf     |  8 ++++++++
>>  t/t5551-http-fetch-smart.sh |  7 +++++++
>>  7 files changed, 61 insertions(+), 10 deletions(-)
>
> This version looks good to me.
>
> -Peff

Thanks, both.