Re: [PATCH] contrib/git-jump: cat output when not a terminal
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 9, 2020, 23:42 UTC
- Message-ID
- <xmqq8si0vfp3.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAFKec1Wj_uK-moVfin3XrTEmmBaAzaJKsh1f8q-3+RBs2-3Jdg@mail.gmail.com>
George Brown <321.george@gmail.com> writes:
Show 11 quoted lines
>> The are editors that open their own window, or tell an already open >> editor instance to edit the buffer (think: emacsclient) and in order >> to be functional, they do not have to be launched from inside a >> working terminal window (whose input comes from the keyboard---the >> test "-t 1" is an approximate check for that). >> >> Wouldn't this change hurt the users of such an editor? > > I'm unsure of emacsclient but I would have thought that editors in > general would be more amenable to receiving lines than relying on > additional spawned instances to behave as clients.
I am not sure what you mean by "receiving lines". Your patch makes the "git jump" command completely ignore configured GIT_EDITOR and refuse to invoke *any* editor.