Re: Re* [PATCH] contrib/git-jump: cat output when not a terminal

From: Jeff King <peff@peff.net>
Date: May 13, 2020, 04:52 UTC
Message-ID: <20200513045238.GB65110@coredump.intra.peff.net>
In-Reply-To: <xmqqy2pwalj9.fsf@gitster.c.googlers.com>

On Tue, May 12, 2020 at 02:30:34PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> >> +edit=yes
> >> +
> >> +while	case "$#,$1" in
> >
> > Tab between "while" and "case"?
> 
> Yup.  Just to align case and its arms.

I guess that makes sense, though I'd probably have used spaces to do so. Having a tab in the middle of the line is unusual.

Show 13 quoted lines

> >> +	0,*) break ;;
> >> +	*,--no-editor) edit=no ;;
> >> +	*,--*) usage >&2; exit 1 ;;
> >> +	*) break ;;
> >> +	esac
> >> +do
> >> +	shift
> >> +done
> >
> > I found the use of "case" in the loop conditional a little unusual.
> 
> It's pretty-much personal preference, I think.  I could replace
> s/break/false/ if you find it easier to understand.

I think the part that most threw me off is looking at the arg-count in each case arm. It's "*" in most, which really means "do not bother to look at it" (which I think is why I found a loop condition on "$# -gt 0" to be more natural).

I can live with it either way.

-Peff