Re: [PATCH] contrib/git-jump: cat output when not a terminal

From: Jeff King <peff@peff.net>
Date: May 11, 2020, 15:42 UTC
Message-ID: <20200511154226.GC1415@coredump.intra.peff.net>
In-Reply-To: <xmqqr1vqscuy.fsf@gitster.c.googlers.com>

On Mon, May 11, 2020 at 08:36:05AM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> > So I'm OK to leave the status quo and let people use the GIT_EDITOR
> > solution in this instance. But I'd also be happy to take a patch for
> > "--no-editor" or similar if somebody wants to work it up.
> 
> I actually would support --no-editor.  One thing nobody noticed so
> far is that "git-jump" is only compatible with editors that support
> the "-q" option from the command line, and "cat" is not among them.

Oh, good point. GIT_EDITOR='cat -- 2>/dev/null' works, but is rather obscure. :)

> Another thing I was thinking about was a change like the attached.
> Plugging it thru "git var" to allow "git var GIT_JUMP_EDITOR" may
> allow vim users to set it to 'cat' while setting GIT_EDITOR to vim.

I wouldn't use it myself, but I don't have any objection to adding support.

>  cache.h  |  2 +-
>  editor.c | 33 ++++++++++++++++++++++-----------

You'd presumably need to make git-var understand that GIT_JUMP_EDITOR should fall back to GIT_EDITOR.

-Peff