Re: [PATCH] contrib/git-jump: cat output when not a terminal
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 10, 2020, 16:47 UTC
- Message-ID
- <xmqqwo5ju47t.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAFKec1UGKbaV7wC78i8+uSEizjGkj2bDSfOeucvJORhORvc5KA@mail.gmail.com>
George Brown <321.george@gmail.com> writes:
> Running "git jump" from a shell prompt works as before with this patch.
I am not worried at all about that use case. It is clear that you had the "shell prompt" in mind from "test -t 1".
Given what "git jump" does, wouldn't it be natural to expect that GUI programs that have no "shell prompt" interaction with the end user want to use "git jump"? It may even be driving a graphical version of vim---or is it impossible for such a GUI program to exist?
As long as such a regression for existing users use is impossible, I think the patch is probably OK, but doing a hardcoded "cat" smells like a very bad hack, compared to a solution on the program's side that *wants* to read the prepared file to arrange that to happen (e.g. via setting the GIT_EDITOR environment to "cat" within that program).
In any case, I am not a "git jump" user, so...