Re: [PATCH] contrib/git-jump: cat output when not a terminal
- From
- George Brown <321.george@gmail.com>
- Date
- May 9, 2020, 22:04 UTC
- Message-ID
- <CAFKec1Wj_uK-moVfin3XrTEmmBaAzaJKsh1f8q-3+RBs2-3Jdg@mail.gmail.com>
- In-Reply-To
- <xmqqd07cvl9b.fsf@gitster.c.googlers.com>
Show 7 quoted lines
> The are editors that open their own window, or tell an already open > editor instance to edit the buffer (think: emacsclient) and in order > to be functional, they do not have to be launched from inside a > working terminal window (whose input comes from the keyboard---the > test "-t 1" is an approximate check for that). > > Wouldn't this change hurt the users of such an editor?
I'm unsure of emacsclient but I would have thought that editors in general would be more amenable to receiving lines than relying on additional spawned instances to behave as clients.
> Would it work to set GIT_EDITOR to "cat" while performing the > "populating quickfix list" (whatever that is) operation?
It would, though I considered this to be less elegant.
Just for background the quickfix list in Vim is simply a list of locations that you can browse and jump to.
On Sat, 9 May 2020 at 22:41, Junio C Hamano <gitster@pobox.com> wrote:
Show 45 quoted lines
>
> George Brown <321.george@gmail.com> writes:
>
> > contrib/git-jump: cat output when not a terminal
> >
> > The current usage to populate Vim's quickfix list cannot be used from
> > within the editor as it invokes another instance.
> >
> > Check if stdout is to a terminal or not. If not simply cat the output.
>
> The are editors that open their own window, or tell an already open
> editor instance to edit the buffer (think: emacsclient) and in order
> to be functional, they do not have to be launched from inside a
> working terminal window (whose input comes from the keyboard---the
> test "-t 1" is an approximate check for that).
>
> Wouldn't this change hurt the users of such an editor?
>
> Would it work to set GIT_EDITOR to "cat" while performing the
> "populating quickfix list" (whatever that is) operation?
>
> > Signed-off-by: George Brown <321.george@gmail.com>
> > ---
> > contrib/git-jump/git-jump | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
> > index 931b0fe3a9..253341c64e 100755
> > --- a/contrib/git-jump/git-jump
> > +++ b/contrib/git-jump/git-jump
> > @@ -19,8 +19,12 @@ EOF
> > }
> >
> > open_editor() {
> > - editor=`git var GIT_EDITOR`
> > - eval "$editor -q \$1"
> > + if test -t 1; then
> > + editor=`git var GIT_EDITOR`
> > + eval "$editor -q \$1"
> > + else
> > + cat "$1"
> > + fi
> > }
> >
> > mode_diff() {