From: Junio C Hamano Date: Sat, 09 May 2020 23:42:00 GMT Subject: Re: [PATCH] contrib/git-jump: cat output when not a terminal Message-ID: In-Reply-To: George Brown <321.george@gmail.com> writes: >> The are editors that open their own window, or tell an already open >> editor instance to edit the buffer (think: emacsclient) and in order >> to be functional, they do not have to be launched from inside a >> working terminal window (whose input comes from the keyboard---the >> test "-t 1" is an approximate check for that). >> >> Wouldn't this change hurt the users of such an editor? > > I'm unsure of emacsclient but I would have thought that editors in > general would be more amenable to receiving lines than relying on > additional spawned instances to behave as clients. I am not sure what you mean by "receiving lines". Your patch makes the "git jump" command completely ignore configured GIT_EDITOR and refuse to invoke *any* editor.