Re: [PATCH] contrib/git-jump: cat output when not a terminal
- From
- George Brown <321.george@gmail.com>
- Date
- May 10, 2020, 19:25 UTC
- Message-ID
- <CAFKec1Uya31withxzAqwFSVxqgxj_RbU1B6NrMYQ4U8WzLOs6g@mail.gmail.com>
- In-Reply-To
- <xmqqk11jtxl3.fsf@gitster.c.googlers.com>
> Imagine a user wanted to spawn a graphical editor via git-jump from within > a GUI script (probably launched from a window manager menu and has no > gqipterminal). With git-jump with this patch, such a use will be broken, no?
Aha OK that's an example that I didn't grok from your earlier mails, I had only been thinking in the context of editors. The reasoning behind the "escape hatch" you describe makes sense.
Show 6 quoted lines
> Unilaterally breaking, and ignoring when you are told you are > breaking, possible existing users, without giving them any escape > hatch, is simply irresponsible, and not something done in this > project. But I am sensing that you are not listening to and > thinking about what you hear before you respond, so I will stop > spending time on this topic for now, and wait until others chime in.
I apologise for not understanding, it was not my intention to be willfully ignorant.