git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib/git-jump: cat output when not a terminal

From
GBGeorge Brown <321.george@gmail.com>
Date
May 10, 2020, 18:34 UTC
Message-ID
<CAFKec1VGzpxVJV4zak46r_p2gGcw4UanFr7U4U4MSsG7t2A23w@mail.gmail.com>
In-Reply-To
<xmqqo8qvu0ao.fsf@gitster.c.googlers.com>

I think with this change all editors can benefit. The format "git jump" is producing is something easily consumed. I think consumption of output from tools is far more common in editors than communication between multiple instances.

As an aside the fact that as is "git jump" invokes "$GIT_EDITOR" with the "-q" option makes an implicit assumption the editor will be Vim or something very much like it. To be very clear I don't mean to say this means only Vim should be considered. However it's also making the implicit assumption that passing the "-q" option is valid for any "$GIT_EDITOR" and does not cause an error like that seen when trying to override "$GIT_EDITOR" with cat. This change means other editors can invoke "git jump" without fear of such a situation, increasing usability.

Arguably the most interoperable way for "git jump" to work would be to output the formatted lines and do nothing else, leaving it to users to choose how to operate upon the output/invoke editors. Of course such a change would break the workflow of anyone who uses "git jump" today and isn't a valid option.

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 21 in “contrib/git-jump: cat output when not a terminal”
  1. contrib/git-jump: cat output when not a terminalGeorge Brown, May 9, 2020
  2. Junio C HamanoMay 9, 2020
  3. George BrownMay 9, 2020
  4. Junio C HamanoMay 9, 2020
  5. George BrownMay 10, 2020
  6. Junio C HamanoMay 10, 2020
  7. George BrownMay 10, 2020
  8. Junio C HamanoMay 10, 2020
  9. George BrownMay 10, 2020
  10. Junio C HamanoMay 10, 2020
  11. George BrownMay 10, 2020
  12. Junio C HamanoMay 10, 2020
  13. George BrownMay 10, 2020
  14. Junio C HamanoMay 11, 2020
  15. Jeff KingMay 11, 2020
  16. Junio C HamanoMay 11, 2020
  17. Jeff KingMay 11, 2020
  18. Re* [PATCH] contrib/git-jump: cat output when not a terminalJunio C Hamano, May 11, 2020
  19. Jeff KingMay 12, 2020
  20. Junio C HamanoMay 12, 2020
  21. Jeff KingMay 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.