Re: [PATCH] contrib/git-jump: cat output when not a terminal

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2020, 18:12 UTC
Message-ID: <xmqqo8qvu0ao.fsf@gitster.c.googlers.com>
In-Reply-To: <CAFKec1Wy1iT8Z=gNDBn++XLxzGWr0UUiu3AKMU-qaR+jj2yoKQ@mail.gmail.com>

George Brown <321.george@gmail.com> writes:

Show 13 quoted lines

>> As long as such a regression for existing users use is impossible, I
>> think the patch is probably OK, but doing a hardcoded "cat" smells
>> like a very bad hack, compared to a solution on the program's side
>> that *wants* to read the prepared file to arrange that to happen
>> (e.g. via setting the GIT_EDITOR environment to "cat" within that
>> program).
>
> I think this change only enhances "git jump".
>
>> In any case, I am not a "git jump" user, so...
>
> I looked into this as other Vim users were talking about it and wanted
> this behavior.

That's already irrelevant in the course of this discussion, no?

We have already established that you wrote in good faith to improve the use experience by vim users, and nobody in this exchange doubts that this change would help vim users.

I am worried about the change hurting non-vim users, but no amount of "me too" from vim users who care only about their vim experience would allay that.