Re: [PATCH] contrib/git-jump: cat output when not a terminal

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2020, 14:31 UTC
Message-ID: <xmqq5zd2tufn.fsf@gitster.c.googlers.com>
In-Reply-To: <CAFKec1VGMwn3_4AEuY8Vrs60UQbX-fvqCkzKd8VARAUScbA=rA@mail.gmail.com>

George Brown <321.george@gmail.com> writes:

> Yes. Another version that someone else implemented used similar method
> by unsetting "$GIT_EDITOR" when invoked from Vim and modified "git jump"
> to use cat when "$GIT_EDITOR" was empty.

That's curious, because with the same approach, that someone else could have gone one step further to set GIT_EDITOR to 'cat' when vim invokes via a macro and then there is no need to modify git-jump at all. "Curious" because I would intuitively think that unsetting GIT_EDITOR and setting it to a specific value, 'cat', would require about the same amount of effort.