From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Jul 2025 17:02:01 GMT
Subject: Re: [PATCH v6 0/5] bloom: enable bloom filter optimization for multiple pathspec elements in revision traversal
Message-ID: <xmqq7c0au2nq.fsf@gitster.g>
In-Reply-To: <0969e176-b9c7-464d-8e97-cf5cd4a06347@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

> On 7/12/2025 5:35 AM, Lidong Yan wrote:
>
>> The difference from v5 is:
>>   - extract convert pathspec item to bloom_keyvec logic to
>>     a separate function, which simplifies the prepare_to_use_bloom_filter()
>>     function.
>>   - fix few bugs in v5.
>
> Thanks for making these changes. Including your fixed patch 5, this
> version looks ready to me.
>
> I wouldn't say "fix a few bugs" but instead "fix some compile-time
> linting complaints when using DEVELOPER=1" to be clear that the
> functionality hasn't changed but the code is cleaner.

Thanks both, for polishing and reviewing.