Re: [PATCH v3 7/8] commit-reach: terminate merge-base walk when one paint side is exhausted

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 26, 2026, 14:32 UTC
Message-ID: <cb82cb80-291b-4a36-ae83-f308560c844b@gmail.com>
In-Reply-To: <CAL71e4N3RPHSrXscwYJUiLWc8-a172h+nE13yuUBRV7Uu3zGzw@mail.gmail.com>

On 6/26/2026 10:29 AM, Kristofer Karlsson wrote:

Show 12 quoted lines

> On Fri, 26 Jun 2026 at 15:08, Kristofer Karlsson via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Kristofer Karlsson <krka@spotify.com>
>>
>> -               if (min_generation && generation > last_gen)
>> +               if (generation > last_gen)
> 
> I have to note that I accidentally pushed this version before noticing
> that it now fails for a subset of commit-graph modes.
> Apologies for that - I will rework the logic here later
> to preserve the behavior better.

And do we catch this with a test case? I'm hoping that you discovered this error through the test suite, even if you submitted the series a little early.

> I think (and hope) the rest of the patch series is in good shape though
> and addressed the previous feedback, so any partial new review
> feedback would still be appreciated.

Thanks for calling this out, as now I can avoid trying to understand this change during my review.

Thanks, -Stolee