Re: [PATCH v7 03/10] t6600: add test cases for side-exhaustion edge cases
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 7, 2026, 15:36 UTC
- Message-ID
- <CABPp-BEOR2rPVH8Uc446rhAATBUQTX+o3YELeV2jU2isnZwnCQ@mail.gmail.com>
- In-Reply-To
- <CAL71e4OZwDzZaE4kfZTcBy8wtdeX2Y8H8XM9x12qH8TaUkVUnw@mail.gmail.com>
On Fri, Aug 7, 2026 at 4:33 AM Kristofer Karlsson <krka@spotify.com> wrote:
Show 25 quoted lines
> > On Fri, 7 Aug 2026 at 05:01, Elijah Newren <newren@gmail.com> wrote: > > > > As the author of these tests, and as my Signed-off-by attests, I can > > confirm with the full weight of my authority that these tests are > > good. > > > > However, I would be remiss not to note the perfidious destruction of > > my two spaces after each period, cruelly collapsed down to a mere one. > > Have you no decency, sir? > > > > (Kidding, of course -- I mostly point it out so the next reviewer can > > appreciate just how little else changed from the original.) > > Oops! The irony here is that I tried to be very careful to not > corrupt your changes and thus the attribution. I was already > somewhat hesitant to even modify the patch to split out the tests > from the code changes. > > I added my own helper script to check and correct patch series > and I had snuck in a double-space remover for personal preference > but I think I will actually get rid of that since there is a slight > preference (but not enforced) for double-space in this community. > > And since I need to reroll _anyway_, I might as well repair this. :)
Heh, I don't think it's worth the effort. I really was just trying to throw a joke in there for anyone reading the archives to enjoy, but the patch is fine either way.