Re: [PATCH v2 0/7] commit-reach: terminate merge-base walk when one side is exhausted

From: Kristofer Karlsson <krka@spotify.com>
Date: Jun 24, 2026, 14:25 UTC
Message-ID: <CAL71e4MnA36ZchLaUsMSoLcb9LO77aac274jES8+oV=yxuigOA@mail.gmail.com>
In-Reply-To: <67c00a9f-2aa2-4e83-9c0a-317ca589b232@gmail.com>

On Wed, 24 Jun 2026 at 15:34, Derrick Stolee <stolee@gmail.com> wrote:

Show 5 quoted lines

>
> I like seeing these updates including the deterministic steps. Is there
> a reason you don't include the step data for 'merge-tree (across import)'
> in your monorepo case? The wall-clock is substantial, so it's not like the
> last two examples in git.git where there may not be any difference.

I will have to attribute to laziness I suppose :) I ran the initial benchmarks before adding the trace, and I didn't update all of them, just enough to show the improvement and value of the trace data.

I will ensure that I include all of it in the next version though (maybe 1-2 days from now?) or maybe drop some of the benchmarks to not overload with partly redundant information. (merge-tree benchmarks doesn't perhaps add much significance on top of merge-base in practice).

Thanks, Kristofer