Re: [PATCH v3 7/8] commit-reach: terminate merge-base walk when one paint side is exhausted

From: Kristofer Karlsson <krka@spotify.com>
Date: Jun 26, 2026, 16:41 UTC
Message-ID: <CAL71e4PcCGbth+CcU0ievjQeK_VnDVwHX=FEvR5jpSkzkr_6GA@mail.gmail.com>
In-Reply-To: <cb82cb80-291b-4a36-ae83-f308560c844b@gmail.com>

On Fri, 26 Jun 2026 at 16:32, Derrick Stolee <stolee@gmail.com> wrote:

Show 9 quoted lines

>
> > I have to note that I accidentally pushed this version before noticing
> > that it now fails for a subset of commit-graph modes.
> > Apologies for that - I will rework the logic here later
> > to preserve the behavior better.
>
> And do we catch this with a test case? I'm hoping that you discovered
> this error through the test suite, even if you submitted the series a
> little early.

(I missed replying to this message initially, sorry)

Yes exactly - it was caught by t6600 but somehow I missed running it before submitting it (so I noticed it in the GGG CI instead)

So the existing tests are good, I only wish I could be equally reliable as them.

Thanks, Kristofer