Re: [PATCH v7 07/10] commit-reach: introduce struct paint_state with per-side counters

From: Kristofer Karlsson <krka@spotify.com>
Date: Aug 7, 2026, 16:00 UTC
Message-ID: <CAL71e4P1hRcDk0TiR_Gjapf=EScGNbeHqSQ6BqeiAkEvczNu4g@mail.gmail.com>
In-Reply-To: <CABPp-BE+QBBYj=oaRDcQj8bFrDX6Z_JVK39ciAk4TwMPb0zHOQ@mail.gmail.com>

On Fri, 7 Aug 2026 at 17:44, Elijah Newren <newren@gmail.com> wrote:

Show 9 quoted lines

>
>
> My comment was meant more as a "review out loud; show how I'm thinking
> about the patch as I read it" kind of comment rather than as a note of
> something worth changing in the patch.  The order _is_ important here,
> so the idea of adding a comment to reinforce it seems quite reasonable
> to consider (I thought about changing my comment to ask for one when
> reviewing), but I'm on the fence about whether it's important enough
> or overkill.  I'm okay with the patch either way.

True, but your thinking out loud fortunately reminded me that I had the same thought process, and that the ordering may not be immediately obvious -- and thus we should document it.

I will add a comment for it...

Show 8 quoted lines

> Although, if you do add one, as per the CodingGuidelines:
>
> /*
>  * Multi-line comments include their delimiters
>  * on separate lines from the text.
>  */
>
> :-)

... and I will be stricter about the formatting in the patches than I was in the email :)

Thanks, Kristofer