Re: [PATCH v7 05/10] commit-reach: add trace2 instrumentation to paint_down_to_common()

From: Kristofer Karlsson <krka@spotify.com>
Date: Aug 7, 2026, 15:57 UTC
Message-ID: <CAL71e4MDRGWeKsmKsRhyFsSBT8+QKbiGZ7+AydRk_Zxb2arn-Q@mail.gmail.com>
In-Reply-To: <CABPp-BHE2KwjcVc14heMhpBLz64eEQ8y6qu56vzXKN9VK12qzA@mail.gmail.com>

On Fri, 7 Aug 2026 at 17:49, Elijah Newren <newren@gmail.com> wrote:

Show 6 quoted lines

>
> I think a short comment in the commit message about the new tests in
> this commit triggering the existing min_generation optimization would
> have dispelled my original misunderstanding and made the review
> easier, and would thus be worthwhile to add for other reviewers or
> future folks running across the commit.

Agreed -- I was initially thinking about adding a comment in the test itself but adding it to the commit message makes a lot more sense. Will fix.

Thanks, Kristofer

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.