Re: [PATCH/RFC 1/6] commit-reach: decouple ahead_behind from nonstale_queue

From: Kristofer Karlsson <krka@spotify.com>
Date: Jun 22, 2026, 18:53 UTC
Message-ID: <CAL71e4MuRXDs_vB7UWq7kXmUVhDHOCv2jKM0NeAj3Cofbt5hcA@mail.gmail.com>
In-Reply-To: <001e8da6-3232-4cfa-ba6b-35d3489e4779@gmail.com>

On Mon, 22 Jun 2026 at 20:00, Derrick Stolee <stolee@gmail.com> wrote:

Show 9 quoted lines

>
> This change is only needed if we are intending to delete the nonstale
> queue struct, which is currently happening in your patch 2. But we
> are essentially recreating its logic in a more disjointed way here,
> leaving this code in a worse state.
>
> I'd rather see patch 2 create a _new_ data structure instead of
> _replacing_ one that already works for multiple callers. (It does
> drop to only one caller, but that seems cleaner to me right now.)

I can definitely do that and leave ahead_behind unchanged for v2. I was thinking that with only a single caller, and ahead_behind being simpler than paint_down in this respect, it would be worthwhile to simplify it, but if so I could instead do that as a standalone follow up (though it may prove to be not enough value for the win).

Thanks, Kristofer