Re: [PATCH v5 00/10] commit-reach: terminate merge-base walk when one side is exhausted

From: Kristofer Karlsson <krka@spotify.com>
Date: Jul 1, 2026, 21:15 UTC
Message-ID: <CAL71e4PgcZDK-gJziJa_yjEqX9TE+PFMwZn0xbjAUzuUDDDBYA@mail.gmail.com>
In-Reply-To: <xmqqpl16mq3v.fsf@gitster.g>

On Wed, 1 Jul 2026 at 22:06, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

>
> I thought that the plan in
>
> https://lore.kernel.org/git/CAL71e4P4GbYYv1LdarAbeodm06q841wj4gdGpn0QYADQjOB5gw@mail.gmail.com/
>
> was to make this v5 on top of kk/commit-reach-find-all-fix topic.
>
> I tried to prepare a merge of kk/commit-reach-find-all-fix into
> v2.55.0 and then used "git am -3" to apply these patches on top,
> but there were conflicts, and after resolving 7/10, t6600 stops
> passing.
>
> Perhaps it is best to ask you rebase these patches on top of a merge
> of kk/commit-reach-find-all-fix into v2.55.0?

You are right, I am sorry about that -- I will wait for kk/commit-reach-find-all-fix to land and then fix up a proper v6.

In the meantime, there are still some aspects of this v5 that would benefit from some discussion and feedback -- specifically the new test diagnostic helper (patch 2) and the commit-date ordering fallback removal (patch 10). Both are new in this version and could be seen as optional.

Thanks, Kristofer