Re: [PATCH/RFC 0/6] commit-reach: terminate merge-base walk when one side is exhausted

From: Derrick Stolee <stolee@gmail.com>
Date: Jun 22, 2026, 18:22 UTC
Message-ID: <a800f1cf-0ba8-49c4-acb2-40b370e33663@gmail.com>
In-Reply-To: <pull.2149.git.1781951820.gitgitgadget@gmail.com>

On 6/20/2026 6:36 AM, Kristofer Karlsson via GitGitGadget wrote:

Show 9 quoted lines

> Hi,
> 
> This follows up on my RFC [1] with a concrete proposal. I expect the design
> to still be scrutinized, but that may be easier with actual code to look at.
> 
> I tried to make this easier to review by splitting into atomic patches. The
> first two patches are the meatiest parts, though they are pure refactoring.
> The behavior change is in patch 3 and is in itself quite small. The last
> patch adds technical documentation to support future development.

Thanks for putting this together carefully.

I gave some feedback on the specific code and the patch organization. Overall, I believe that this implementation is functionally correct and everything I have to say is about presentation and data gathering.

I look forward to a non-RFC v2.

Thanks, -Stolee