Re: [PATCH 04/40] Windows: Use the Windows style PATH separator ';'.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 29, 2008, 12:59 UTC
Message-ID: <alpine.LSU.1.00.0802291257150.22527@racer.site>
In-Reply-To: <47C7FE7B.3030309@gnu.org>

Hi,

On Fri, 29 Feb 2008, Paolo Bonzini wrote:

Show 10 quoted lines

> > However, there is something ugly waiting for us: we often have
> > 
> > 	case '/':
> > 
> > and for Windows, this needs to add
> > 
> > 	case '\\':
> 
> More often than in an "if" statement (so you can add IS_DIR_SEPARATOR 
> which is much less ugly than CASE_DIR_SEPARATOR)?

I have not grepped through the patches (as yourself, I am too lazy), but I remember seeing the "case" case in two instances, and I do not remember seeing the "if" case.

In the end, I think suggesting something like PATH_SEPARATOR is good. But insisting on it without working on it is less good.

So I think that it is up to Hannes now; he got enough input, and he has a fine sense of taste, so he will do the Right Thing.

Ciao, Dscho