Re: [PATCH 27/40] Windows: Implement a custom spawnve().
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 29, 2008, 01:18 UTC
- Message-ID
- <alpine.LSU.1.00.0802290117540.22527@racer.site>
- In-Reply-To
- <200802282204.20168.johannes.sixt@telecom.at>
Hi,
On Thu, 28 Feb 2008, Johannes Sixt wrote:
Show 10 quoted lines
> On Thursday 28 February 2008 16:36, Johannes Schindelin wrote: > > On Wed, 27 Feb 2008, Johannes Sixt wrote: > > > - cmd->pid = spawnvpe(_P_NOWAIT, cmd->argv[0], cmd->argv, (const > char**)env); > > > + cmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env); > > > > Should this not be "#define spawnvpe mingw_spanvpe" in git-compat-util.h > > instead? > > No. We don't mimic the API of the original spawnvpe. Why obfuscate this fact?
Oops. I forgot that. Maybe we do not want to call the function mingw_spawnvpe(), then? (That fact is what made me believe that the #define was a good idea, after all.)
Ciao, Dscho