Re: [PATCH 03/40] Add target architecture MinGW.
- From
Paolo Bonzini <bonzini@gnu.org>
- Date
- Feb 28, 2008, 12:57 UTC
- Message-ID
- <47C6AFA4.9040304@gnu.org>
- In-Reply-To
- <alpine.LSU.1.00.0802281159550.22527@racer.site>
Johannes Schindelin wrote:
Show 11 quoted lines
> Hi,
>
> On Wed, 27 Feb 2008, Johannes Sixt wrote:
>
>> +int gettimeofday(struct timeval *tv, void *tz)
>> +{
>> + return 0;
>> +}
>
> Should it not return -1, for failure? (I know, I know, probably a few
> programs do not work, then, but it is not correct that it succeeded.)FWIW, this is overwritten by later patches in the series anyway.
All the other suggestions that Dscho wrote about, make a lot of sense to me too.
Paolo