Re: [PATCH 02/40] Compile some programs only conditionally.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 28, 2008, 11:57 UTC
Message-ID: <alpine.LSU.1.00.0802281146050.22527@racer.site>
In-Reply-To: <1204138503-6126-3-git-send-email-johannes.sixt@telecom.at>

Hi,

On Wed, 27 Feb 2008, Johannes Sixt wrote:

> On MinGW, we won't compile some programs.

This explanation is good (even if I recall that we compile git-daemon.exe just fine now).

Show 6 quoted lines

> @@ -264,7 +263,7 @@ PROGRAMS = \
>  	git-update-server-info$X \
>  	git-upload-pack$X \
>  	git-pack-redundant$X git-var$X \
> -	git-merge-tree$X git-imap-send$X \
> +	git-merge-tree$X \

We do not compile git-imap-send because MinGW lacks socketpair() and getpass(). Why not say it explicitely, and have a NO_SOCKETPAIR variable? Likewise, for git-daemon we should say NO_SYSLOG.

> +ifndef NO_EXTRA_PROGRAMS

The name NO_EXTRA_PROGRAMS is definitely not illustrating the reasons why we exclude those programs, so I'd rather not have this patch as-is.

NOTE: I think that both programs are fixable, but only git-daemon is 
important enough that I would like to see patch of the "daemon" branch in 
4msysgit.git cherry picked into this series (maybe we should implement a 
compat/syslog.c using the ReportEvent() function of the win32 API?).

Ciao, Dscho