Re: [PATCH 04/40] Windows: Use the Windows style PATH separator ';'.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 29, 2008, 01:09 UTC
Message-ID: <alpine.LSU.1.00.0802290108530.22527@racer.site>
In-Reply-To: <200802282143.19322.johannes.sixt@telecom.at>

Hi,

On Thu, 28 Feb 2008, Johannes Sixt wrote:

Show 17 quoted lines

> On Thursday 28 February 2008 10:25, Paolo Bonzini wrote:
> > > +#ifdef __MINGW32__
> > > +		strbuf_addch(out, ';');
> > > +#else
> > >  		strbuf_addch(out, ':');
> > > +#endif
> >
> > Why not adding a PATH_SEPARATOR #define?
> 
> Because IMO it is obfuscating:
> 
> 1. When you read through the code and see PATH_SEPARATOR, you still have
> to go look how it's defined. Why? Because you always will ask: Is this 
> about ':' vs. ';' or '/' vs. '\\'?
> 
> 2. When you look for where ":" or ";" are treated, you'll end up at the
> #define. Then you need an extra step to search for PATH_SEPARATOR.

IMO these are not good arguments. If they were, we could not typedef size_t and socklen_t, either.

Ciao, Dscho