git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/40] Windows: Implement setitimer() and sigaction().

From
Johannes Sixt <johannes.sixt@telecom.at>
Date
Feb 27, 2008, 18:54 UTC
Message-ID
<1204138503-6126-15-git-send-email-johannes.sixt@telecom.at>
In-Reply-To
<1204138503-6126-1-git-send-email-johannes.sixt@telecom.at>

The timer is implemented using a thread that calls the signal handler at regular intervals.

We also replace Windows's signal() function because we must intercept that SIGALRM is set (which is used when a timer is canceled).

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
 compat/mingw.c    |  111 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 git-compat-util.h |    3 +
 2 files changed, 113 insertions(+), 1 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 24f783b..4888a03 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -129,12 +129,121 @@ struct passwd *getpwuid(int uid)
 	return &p;
 }
 
-int setitimer(int type, struct itimerval *in, struct itimerval *out)
+static HANDLE timer_event;
+static HANDLE timer_thread;
+static int timer_interval;
+static int one_shot;
+static sig_handler_t timer_fn = SIG_DFL;
+
+/* The timer works like this:
+ * The thread, ticktack(), is basically a trivial routine that most of the
+ * time only waits to receive the signal to terminate. The main thread
+ * tells the thread to terminate by setting the timer_event to the signalled
+ * state.
+ * But ticktack() does not wait indefinitely; instead, it interrupts the
+ * wait state every now and then, namely exactly after timer's interval
+ * length. At these opportunities it calls the signal handler.
+ */
+
+static __stdcall unsigned ticktack(void *dummy)
+{
+	while (WaitForSingleObject(timer_event, timer_interval) == WAIT_TIMEOUT) {
+		if (timer_fn == SIG_DFL)
+			die("Alarm");
+		if (timer_fn != SIG_IGN)
+			timer_fn(SIGALRM);
+		if (one_shot)
+			break;
+	}
+	return 0;
+}
+
+static int start_timer_thread(void)
 {
+	timer_event = CreateEvent(NULL, FALSE, FALSE, NULL);
+	if (timer_event) {
+		timer_thread = (HANDLE) _beginthreadex(NULL, 0, ticktack, NULL, 0, NULL);
+		if (!timer_thread )
+			return errno = ENOMEM,
+				error("cannot start timer thread");
+	} else
+		return errno = ENOMEM,
+			error("cannot allocate resources timer");
 	return 0;
 }
 
+static void stop_timer_thread(void)
+{
+	if (timer_event)
+		SetEvent(timer_event);	/* tell thread to terminate */
+	if (timer_thread) {
+		int rc = WaitForSingleObject(timer_thread, 1000);
+		if (rc == WAIT_TIMEOUT)
+			error("timer thread did not terminate timely");
+		else if (rc != WAIT_OBJECT_0)
+			error("waiting for timer thread failed: %lu",
+			      GetLastError());
+		CloseHandle(timer_thread);
+	}
+	if (timer_event)
+		CloseHandle(timer_event);
+	timer_event = NULL;
+	timer_thread = NULL;
+}
+
+static inline int is_timeval_eq(const struct timeval *i1, const struct timeval *i2)
+{
+	return i1->tv_sec == i2->tv_sec && i1->tv_usec == i2->tv_usec;
+}
+
+int setitimer(int type, struct itimerval *in, struct itimerval *out)
+{
+	static const struct timeval zero;
+	static int atexit_done;
+
+	if (out != NULL)
+		return errno = EINVAL,
+			error("setitmer param 3 != NULL not implemented");
+	if (!is_timeval_eq(&in->it_interval, &zero) &&
+	    !is_timeval_eq(&in->it_interval, &in->it_value))
+		return errno = EINVAL,
+			error("setitmer: it_interval must be zero or eq it_value");
+
+	if (timer_thread)
+		stop_timer_thread();
+
+	if (is_timeval_eq(&in->it_value, &zero) &&
+	    is_timeval_eq(&in->it_interval, &zero))
+		return 0;
+
+	timer_interval = in->it_value.tv_sec * 1000 + in->it_value.tv_usec / 1000;
+	one_shot = is_timeval_eq(&in->it_interval, &zero);
+	if (!atexit_done) {
+		atexit(stop_timer_thread);
+		atexit_done = 1;
+	}
+	return start_timer_thread();
+}
+
 int sigaction(int sig, struct sigaction *in, struct sigaction *out)
 {
+	if (sig != SIGALRM)
+		return errno = EINVAL,
+			error("sigaction only implemented for SIGALRM");
+	if (out != NULL)
+		return errno = EINVAL,
+			error("sigaction: param 3 != NULL not implemented");
+
+	timer_fn = in->sa_handler;
 	return 0;
 }
+
+#undef signal
+sig_handler_t mingw_signal(int sig, sig_handler_t handler)
+{
+	if (sig != SIGALRM)
+		return signal(sig, handler);
+	sig_handler_t old = timer_fn;
+	timer_fn = handler;
+	return old;
+}
diff --git a/git-compat-util.h b/git-compat-util.h
index c576f5a..483ace2 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -602,6 +602,9 @@ char *mingw_getcwd(char *pointer, int len);
 int mingw_rename(const char*, const char*);
 #define rename mingw_rename
 
+sig_handler_t mingw_signal(int sig, sig_handler_t handler);
+#define signal mingw_signal
+
 #endif /* __MINGW32__ */
 
 #endif
-- 
1.5.4.1.126.ge5a7d
Previous: Johannes SixtNext: Johannes Sixt
Message 70 of 138 in “MinGW port”
  1. 00/40 MinGW portJohannes Sixt, Feb 27, 2008
  2. 01/40 Add compat/regex.[ch] and compat/fnmatch.[ch].Johannes Sixt, Feb 27, 2008
  3. Johannes SchindelinFeb 27, 2008
  4. 02/40 Compile some programs only conditionally.Johannes Sixt, Feb 27, 2008
  5. Johannes SchindelinFeb 28, 2008
  6. Johannes SixtFeb 28, 2008
  7. Johannes SchindelinFeb 29, 2008
  8. Johannes SixtFeb 29, 2008
  9. Johannes SchindelinFeb 29, 2008
  10. 03/40 Add target architecture MinGW.Johannes Sixt, Feb 27, 2008
  11. Johannes SchindelinFeb 28, 2008
  12. Paolo BonziniFeb 28, 2008
  13. Johannes SchindelinFeb 28, 2008
  14. Johannes SixtFeb 28, 2008
  15. Johannes SchindelinFeb 29, 2008
  16. Johannes SixtFeb 29, 2008
  17. Johannes SchindelinFeb 29, 2008
  18. Johannes SixtMar 5, 2008
  19. Johannes SchindelinMar 5, 2008
  20. Junio C HamanoMar 5, 2008
  21. Johannes SchindelinMar 5, 2008
  22. Junio C HamanoMar 5, 2008
  23. Johannes SchindelinMar 6, 2008
  24. 1/2 Add strbuf_initf()Johannes Schindelin, Mar 6, 2008
  25. Mike HommeyMar 6, 2008
  26. Reece DunnMar 6, 2008
  27. Johannes SchindelinMar 6, 2008
  28. Reece DunnMar 6, 2008
  29. Johannes SchindelinMar 6, 2008
  30. 1/2 Add strbuf_vaddf(), use it in strbuf_addf(), and add strbuf_initf()Johannes Schindelin, Mar 6, 2008
  31. Johannes SixtMar 6, 2008
  32. Johannes SixtMar 6, 2008
  33. Johannes SchindelinMar 6, 2008
  34. Kristian HøgsbergMar 6, 2008
  35. Johannes SchindelinMar 6, 2008
  36. Kristian HøgsbergMar 6, 2008
  37. Mike HommeyMar 6, 2008
  38. Johannes SchindelinMar 6, 2008
  39. Jeff KingMar 6, 2008
  40. 2/2 format-patch: add --reviewed-by=<ident>Johannes Schindelin, Mar 6, 2008
  41. Junio C HamanoMar 6, 2008
  42. Johannes SchindelinMar 6, 2008
  43. Johannes SixtMar 6, 2008
  44. Johannes SixtMar 11, 2008
  45. Johannes SchindelinMar 11, 2008
  46. Johannes SixtMar 12, 2008
  47. Johannes SchindelinMar 12, 2008
  48. 04/40 Windows: Use the Windows style PATH separator ';'.Johannes Sixt, Feb 27, 2008
  49. Paolo BonziniFeb 28, 2008
  50. Johannes SixtFeb 28, 2008
  51. Johannes SchindelinFeb 29, 2008
  52. Paolo BonziniFeb 29, 2008
  53. Johannes SchindelinFeb 29, 2008
  54. Paolo BonziniFeb 29, 2008
  55. Johannes SchindelinFeb 29, 2008
  56. Junio C HamanoFeb 28, 2008
  57. 05/40 Windows: Strip ".exe" from the program name.Johannes Sixt, Feb 27, 2008
  58. 06/40 Windows: Implement a wrapper of the open() function.Johannes Sixt, Feb 27, 2008
  59. 07/40 Windows: A minimal implemention of getpwuid().Johannes Sixt, Feb 27, 2008
  60. 08/40 Windows: always chmod(, 0666) before unlink().Johannes Sixt, Feb 27, 2008
  61. Johannes SchindelinFeb 28, 2008
  62. 09/40 Windows: Work around misbehaved rename().Johannes Sixt, Feb 27, 2008
  63. 10/40 Windows: Treat Windows style path names.Johannes Sixt, Feb 27, 2008
  64. Johannes SchindelinFeb 28, 2008
  65. 11/40 Windows: Handle absolute paths in safe_create_leading_directories().Johannes Sixt, Feb 27, 2008
  66. 12/40 Windows: Implement gettimeofday().Johannes Sixt, Feb 27, 2008
  67. 13/40 Windows: Fix PRIuMAX definition.Johannes Sixt, Feb 27, 2008
  68. Johannes SchindelinFeb 28, 2008
  69. Johannes SixtFeb 28, 2008
  70. 14/40 Windows: Implement setitimer() and sigaction().Johannes Sixt, Feb 27, 2008
  71. 15/40 Windows: A work-around for a misbehaved vsnprintf.Johannes Sixt, Feb 27, 2008
  72. 16/40 Windows: Wrap execve so that shell scripts can be invoked.Johannes Sixt, Feb 27, 2008
  73. 17/40 Windows: A pipe() replacement whose ends are not inherited to children.Johannes Sixt, Feb 27, 2008
  74. 18/40 Windows: Implement start_command().Johannes Sixt, Feb 27, 2008
  75. 19/40 Windows: Change the name of hook scripts to make them not executable.Johannes Sixt, Feb 27, 2008
  76. Johannes SchindelinFeb 28, 2008
  77. Johannes SixtFeb 28, 2008
  78. Johannes SchindelinFeb 29, 2008
  79. 20/40 Windows: A rudimentary poll() emulation.Johannes Sixt, Feb 27, 2008
  80. Paolo BonziniFeb 28, 2008
  81. Johannes SixtFeb 28, 2008
  82. Robin RosenbergMar 1, 2008
  83. Johannes SixtMar 1, 2008
  84. 21/40 Windows: Disambiguate DOS style paths from SSH URLs.Johannes Sixt, Feb 27, 2008
  85. Johannes SchindelinFeb 28, 2008
  86. Johannes SixtFeb 28, 2008
  87. 22/40 Windows: Implement asynchronous functions as threads.Johannes Sixt, Feb 27, 2008
  88. Johannes SchindelinFeb 28, 2008
  89. Paul FranzFeb 28, 2008
  90. Johannes SchindelinFeb 29, 2008
  91. Paul FranzFeb 29, 2008
  92. Johannes SchindelinFeb 29, 2008
  93. Paul FranzFeb 29, 2008
  94. Junio C HamanoFeb 29, 2008
  95. Paul FranzFeb 29, 2008
  96. Johannes SchindelinFeb 29, 2008
  97. Johannes SixtFeb 28, 2008
  98. Johannes SchindelinFeb 29, 2008
  99. 23/40 Windows: Local clone must use the drive letter in absolute paths.Johannes Sixt, Feb 27, 2008
  100. Johannes SchindelinFeb 28, 2008
  101. 24/40 Windows: Work around incompatible sort and find.Johannes Sixt, Feb 27, 2008
  102. 25/40 Windows: Implement a cpio emulation in git-clone.sh.Johannes Sixt, Feb 27, 2008
  103. 26/40 Windows: Implement wrappers for gethostbyname(), socket(), and connect().Johannes Sixt, Feb 27, 2008
  104. 27/40 Windows: Implement a custom spawnve().Johannes Sixt, Feb 27, 2008
  105. Johannes SchindelinFeb 28, 2008
  106. Johannes SixtFeb 28, 2008
  107. Johannes SchindelinFeb 29, 2008
  108. 28/40 Windows: Add a new lstat and fstat implementation based on Win32 API.Johannes Sixt, Feb 27, 2008
  109. 29/40 Windows: Use a customized struct stat that also has the st_blocks member.Johannes Sixt, Feb 27, 2008
  110. 30/40 Turn builtin_exec_path into a function.Johannes Sixt, Feb 27, 2008
  111. 31/40 Compute the ultimate fallback for exec_path from the program invocation.Johannes Sixt, Feb 27, 2008
  112. 32/40 Windows: Use a relative default template_dir and ETC_GITCONFIGJohannes Sixt, Feb 27, 2008
  113. 33/40 When installing, be prepared that template_dir may be relative.Johannes Sixt, Feb 27, 2008
  114. Paolo BonziniFeb 28, 2008
  115. Johannes SchindelinFeb 28, 2008
  116. Paolo BonziniFeb 28, 2008
  117. Johannes SixtFeb 28, 2008
  118. Johannes SchindelinFeb 29, 2008
  119. 34/40 Windows: Make the pager work.Johannes Sixt, Feb 27, 2008
  120. 35/40 Windows: Work around an oddity when a pipe with no reader is written to.Johannes Sixt, Feb 27, 2008
  121. 36/40 Avoid the "dup dance" in wt_status_print_verbose() when possible.Johannes Sixt, Feb 27, 2008
  122. Johannes SchindelinFeb 28, 2008
  123. 37/40 Windows: Make 'git help -a' work.Johannes Sixt, Feb 27, 2008
  124. Paolo BonziniFeb 28, 2008
  125. 38/40 Windows: TMP and TEMP environment variables specify a temporary directory.Johannes Sixt, Feb 27, 2008
  126. 39/40 Windows: Fix ntohl() related warnings about printf formattingJohannes Sixt, Feb 27, 2008
  127. 40/40 compat/pread.c: Add foward decl to fix warningJohannes Sixt, Feb 27, 2008
  128. Johannes SchindelinFeb 28, 2008
  129. Marius Storm-OlsenFeb 27, 2008
  130. Martin LanghoffFeb 27, 2008
  131. Nguyen Thai Ngoc DuyFeb 28, 2008
  132. Johannes SchindelinFeb 27, 2008
  133. Johannes SixtMar 2, 2008
  134. Johannes SchindelinMar 2, 2008
  135. Johannes SixtMar 3, 2008
  136. Govind SalinasFeb 29, 2008
  137. Johannes SixtFeb 29, 2008
  138. Brian DessentFeb 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.