Re: [PATCH 03/40] Add target architecture MinGW.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 29, 2008, 01:07 UTC
Message-ID: <alpine.LSU.1.00.0802290105150.22527@racer.site>
In-Reply-To: <200802282140.30654.johannes.sixt@telecom.at>

Hi,

On Thu, 28 Feb 2008, Johannes Sixt wrote:

Show 16 quoted lines

> On Thursday 28 February 2008 13:05, Johannes Schindelin wrote:
> >
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> > 
> > > +#ifdef __MINGW32__
> > > +int mkstemp(char *template);
> > > +#endif
> > > +
> > >  static inline int xmkstemp(char *template)
> > >  {
> > >  	int fd;
> >
> > Could we have this...
> 
> No, becauser xmkstemp needs the forward declaration of mkstemp(). But we 
> could make it unconditional.

Actually, I was thinking of including it at the same spot where you declare mkstemp conditionally. (Of course, since I spotted very well that you need that declaration for xmkstemp().)

> I thought about this, but I decided against it:  git-compat-util.h is 
> the place to look for compatibility functions. A file compat/mingw.h 
> only introduces an extra indirection and only *hides* stuff instead of 
> making it obvious.

Well, the thing is, there are quite a few definitions and declarations that are _only_ _ever_ interesting if you are on MinGW32.

So maybe it is a good idea to hide it to all the other users.

Ciao, Dscho