Re: [PATCH 33/40] When installing, be prepared that template_dir may be relative.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 29, 2008, 01:21 UTC
Message-ID: <alpine.LSU.1.00.0802290119340.22527@racer.site>
In-Reply-To: <200802282212.02683.johannes.sixt@telecom.at>

Hi,

On Thu, 28 Feb 2008, Johannes Sixt wrote:

Show 19 quoted lines

> On Thursday 28 February 2008 16:45, Johannes Schindelin wrote:
>
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> > > @@ -1094,6 +1094,13 @@ remove-dashes:
> > >
> > >  ### Installation rules
> > >
> > > +ifeq ($(firstword $(subst /, ,$(template_dir))),..)
> >
> > How portable is "firstword"?  Would it not be better to use
> 
> How portable is "patsubst"? ;)
> 
> > ifneq ($(patsubst ../%,,$(template_dir)),)
> 
> This programming language is sort of write-only, so I don't know because 
> I can't read it ;) If you have tested your version and it works and you 
> have thought through all consequences (like how does it work if 
> template_dir=/a/../b), why not?

I did not think through all consequences, but hoped that some knowledgable person could tell me that/if I am wrong in my assumption that patsubst is older than firstword.

Since I encountered "firstword" for the very first time today, I thought it might be younger than "patsubst", which I met plenty a times.

Ciao, Dscho