Re: [PATCH 03/40] Add target architecture MinGW.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 28, 2008, 14:56 UTC
- Message-ID
- <alpine.LSU.1.00.0802281455440.22527@racer.site>
- In-Reply-To
- <47C6AFA4.9040304@gnu.org>
Hi,
On Thu, 28 Feb 2008, Paolo Bonzini wrote:
Show 13 quoted lines
> Johannes Schindelin wrote:
>
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> >
> > > +int gettimeofday(struct timeval *tv, void *tz)
> > > +{
> > > + return 0;
> > > +}
> >
> > Should it not return -1, for failure? (I know, I know, probably a few
> > programs do not work, then, but it is not correct that it succeeded.)
>
> FWIW, this is overwritten by later patches in the series anyway.Yes, I know that. But the whole point of having a nice patch series is to have proper revisions, and IMO returning 0 here is not correct.
Ciao, Dscho