Re: [PATCH] color-words: Support diff.color-words config option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 21, 2009, 08:25 UTC
Message-ID: <alpine.DEB.1.00.0901210923580.7929@racer>
In-Reply-To: <200901202146.58651.bss@iguanasuicide.net>

Hi,

On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote:

> It uses "diff.wordregex" for reasons mention by Dscho and because that 
> was already what the diff drivers were using.

To be fair, Jakub and Junio mentioned it, too.

Show 5 quoted lines

> I'm not entirely satisfied with it.  There should probably be some way 
> to force the default behavior (which is a bit faster) even if a global 
> config or diff driver exists.  Also, I think camelCase is better than 
> runtogether so I'd prefer to change "wordregex" -> "wordRegex" across 
> the entire patch set.

Well, the thing is, it _should_ be "wordRegex", _except_ in the strcmp() because the config helpers get a downcased key.

Ciao, Dscho