Re: [PATCH] color-words: Support diff.color-words config option

From: Boyd Stephen Smith Jr. <bss@iguanasuicide.net>
Date: Jan 21, 2009, 16:09 UTC
Message-ID: <200901211009.36081.bss@iguanasuicide.net>
In-Reply-To: <alpine.DEB.1.00.0901210923580.7929@racer>

On Wednesday 21 January 2009, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote about 'Re: [PATCH] color-words: Support diff.color-words config option':

Show 9 quoted lines

>On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote:
>> I'm not entirely satisfied with it.  There should probably be some way
>> to force the default behavior (which is a bit faster) even if a global
>> config or diff driver exists.  Also, I think camelCase is better than
>> runtogether so I'd prefer to change "wordregex" -> "wordRegex" across
>> the entire patch set.
>
>Well, the thing is, it _should_ be "wordRegex", _except_ in the strcmp()
>because the config helpers get a downcased key.

It would have been nice to know that last night. I spent far longer than I should have on the "wordregex" -> "wordRegex" patch.

-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/