Re: [PATCH take 3 0/4] color-words improvements

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 15, 2009, 12:41 UTC
Message-ID: <alpine.DEB.1.00.0901151337080.3586@pacific.mpi-cbg.de>
In-Reply-To: <8763khtbfc.fsf@iki.fi>

Hi,

On Thu, 15 Jan 2009, Teemu Likonen wrote:

Show 19 quoted lines

> Johannes Schindelin (2009-01-14 23:06 +0100) wrote:
> 
> > On Wed, 14 Jan 2009, Thomas Rast wrote:
> >>       -aaa [aaa]
> >>       +aaa (aaa) aaa
> >> 
> >> would still give you
> >> 
> >>       aaa (aaa)<GREEN> aaa<RESET>
> >> 
> >> which may be unexpected.
> >
> > But why should it be unexpected?  If people say that every length of "a" 
> > makes a word, and consequently everything else is clutter, then that's 
> > that, no?
> 
> It works logically but I'd very much like to see a some kind of advice
> in the man page. I already faced this (unexpected) situation and wasn't
> able to fix the regexp myself.

Exactly because it works logically, I do not want to change it. This is what the user said, and for a change, it could be what the user meant.

You'll have to come up with a method to describe exactly what you want. So what is it exactly? What would you want in such a situation? You asked for words that consist solely of the letter 'a'. Now, the surrounding stuff differs. What should Git do?

BTW this gets even worse when you compare the following:

bbb aaa ccc aaa

--color-words=a+ will show

ccc aaa

(!!!)

Ciao, Dscho