Re: [PATCH v4 0/7] customizable --color-words

From: Santi Béjar <santi@agolina.net>
Date: Jan 18, 2009, 15:05 UTC
Message-ID: <adf1fd3d0901180705s260f0051wb4e3a978601618ec@mail.gmail.com>
In-Reply-To: <1232209788-10408-1-git-send-email-trast@student.ethz.ch>

2009/1/17 Thomas Rast <trast@student.ethz.ch>:

Show 10 quoted lines

> Johannes Schindelin wrote:
>> Thomas, could you pick up the patches from my 'my-next' branch and
>> maintain an "official" topic branch?
>
> I cherry-picked the three commits you had there, and rebuilt on top.
> I pushed them to
>
>  git://repo.or.cz/git/trast.git tr/word-diff-p2
>
> again (js/word-diff-p1 again points directly at your half).

I've tested tr/word-diff-p2 and I have not found any issues. I've even tested that nothing changed from the tradicional word diff to:

git log -p --color-words="[^[:space:]]+"

for the whole git history.

At the end I've found that a general regex that works best for me is:

"[[:alpha:]]+|[[:digit:]]+|[^[:alnum:][:space:]]"

and that is what I tested.

Santi