Re: [PATCH take 3 0/4] color-words improvements

From: Thomas Rast <trast@student.ethz.ch>
Date: Jan 14, 2009, 20:04 UTC
Message-ID: <200901142104.16134.trast@student.ethz.ch>
In-Reply-To: <alpine.DEB.1.00.0901141840100.3586@pacific.mpi-cbg.de>

Johannes Schindelin wrote:

> 
> The only "funny" thing I realized is that the lines which are output
> by emit_line() add a RESET at the end of the line, and I do not do that
> in color_fwrite_lines().

Umm.... but you seem to do?

Ack on the new regex semantics, though I'd have implemented it via dying on '\n' instead of silently splitting there (and restarting a new match!). [I actually _have_ implemented it, but your patch beat me to it. :-)]

Thus, Ack on 4/4 once the boundary bug is fixed. Thanks for your work!

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.