Re: [PATCH] diff: Support diff.color-words config option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 20, 2009, 17:14 UTC
Message-ID: <alpine.DEB.1.00.0901201810170.5159@intel-tinevez-2-302>
In-Reply-To: <200901201053.03256.bss@iguanasuicide.net>

Hi,

On Tue, 20 Jan 2009, Boyd Stephen Smith Jr. wrote:

> You are up too late Dscho.

You, sir, are absolutely correct.

Show 5 quoted lines

> >Let's squash the two, okay?
> 
> Will do.  I expected the code changes to be larger than the test, and 
> when I finished it was completely the other way.  My next patch will be 
> all-in-one.

FWIW I think it is the correct thing to start with the test script, so that you get a better idea what to look out for.

And for patches of which I don't know if they are still necessary, I like to "git checkout <name>^ && make -j50 && git checkout <name> && (cd t && sh <test>)".

But for submission, I think it makes sense to squash them, except if you submit a bug report with a test script to show the validity of the report first, and only later decide that you want to fix it yourself.

Ciao, Dscho