Re: [PATCH take 3 0/4] color-words improvements

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 14, 2009, 21:07 UTC
Message-ID: <alpine.DEB.1.00.0901142203190.3586@pacific.mpi-cbg.de>
In-Reply-To: <200901142104.16134.trast@student.ethz.ch>

Hi,

On Wed, 14 Jan 2009, Thomas Rast wrote:

Show 7 quoted lines

> Johannes Schindelin wrote:
> > 
> > The only "funny" thing I realized is that the lines which are output
> > by emit_line() add a RESET at the end of the line, and I do not do that
> > in color_fwrite_lines().
> 
> Umm.... but you seem to do?

Oh, right! I think the culprit is in fn_out_diff_words_aux(), which calls fwrite() directly for the common words.

> Ack on the new regex semantics, though I'd have implemented it via dying 
> on '\n' instead of silently splitting there (and restarting a new 
> match!).

Hmm.  I'd rather not die() in the middle of it.

Maybe we can even handle newlines correctly by replacing them with NULs which libxdiff handles just fine?

> Thus, Ack on 4/4 once the boundary bug is fixed.  Thanks for your work!

Phew.  I was almost convinced you would hate me for my criticiscm.

Thanks, Dscho